-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing exposing ReactDelegate through ReactActivity for reload() #44227
Closed
arushikesarwani94
wants to merge
1
commit into
facebook:main
from
arushikesarwani94:export-D56497700
Closed
Fixing exposing ReactDelegate through ReactActivity for reload() #44227
arushikesarwani94
wants to merge
1
commit into
facebook:main
from
arushikesarwani94:export-D56497700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Apr 23, 2024
This pull request was exported from Phabricator. Differential Revision: D56497700 |
…ebook#44227) Summary: In facebook#44223 kudo identified the incorrect return type. Differential Revision: D56497700
arushikesarwani94
force-pushed
the
export-D56497700
branch
from
April 23, 2024 23:31
f288e0b
to
dec2a7d
Compare
This pull request was exported from Phabricator. Differential Revision: D56497700 |
Base commit: 995d5b8 |
This pull request has been merged in e25860f. |
This pull request was successfully merged by @arushikesarwani94 in e25860f. When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 24, 2024
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
…ebook#44227) Summary: Pull Request resolved: facebook#44227 In facebook#44223 kudo identified the incorrect return type. Reviewed By: christophpurrer, philIip Differential Revision: D56497700 fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…ebook#44227) Summary: Pull Request resolved: facebook#44227 In facebook#44223 kudo identified the incorrect return type. Reviewed By: christophpurrer, philIip Differential Revision: D56497700 fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In #44223 @Kudo identified the incorrect return type.
Differential Revision: D56497700